Re: gSoC - ADD MERGE COMMAND - code patch submission

Поиск
Список
Период
Сортировка
От David Fetter
Тема Re: gSoC - ADD MERGE COMMAND - code patch submission
Дата
Msg-id 20100710200339.GF5477@fetter.org
обсуждение исходный текст
Ответ на Re: gSoC - ADD MERGE COMMAND - code patch submission  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: gSoC - ADD MERGE COMMAND - code patch submission  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Sat, Jul 10, 2010 at 01:53:53PM -0400, Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
> > By the way, "make check" fails here with attached initdb.log:
> 
> > creating system views ... FATAL:  unrecognized token: "false"
> 
> Hm, I'd suspect something fouled up in keyword recognition.  Did you
> do a "make clean" and rebuild?

I did make maintainer-clean.

> BTW, this patch is still a few bricks shy of a load, since there's
> no kwlist.h change and so the new MERGE keyword couldn't possibly be
> recognized.  More generally, I'm wondering why the original .rar
> submission was 300k (presumably compressed) and your diff is only
> about 35k ...

I'll look into that.  From what you can see, is it worth trying to
clean up, starting from base, or should we just wait for the next
revision of the patch?

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: gSoC - ADD MERGE COMMAND - code patch submission
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: ALTER TABLE SET STATISTICS requires AccessExclusiveLock