On Sat, Jul 10, 2010 at 10:39:02AM -0700, David Fetter wrote:
> On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote:
> > Robert Haas <robertmhaas@gmail.com> writes:
> > > Though, if the worst problem with this patch is the formatting, we're doing *quite* well.
> >
> > Well, the worst problem with it is that it hasn't touched the
> > interesting part, ie, what happens at execution time. I haven't
> > seen a design for that, which means it's impossible to evaluate
> > whether the code that is here is of any use. We might need some
> > other representation entirely.
> >
> > BTW, Fetter's version of the patch seems to be lacking any gram.y
> > changes, but surely those exist already?
>
> Oops.
>
> Fixed that now in attached patch.
By the way, "make check" fails here with attached initdb.log:
./pg_regress --inputdir=. --dlpath=. --multibyte=SQL_ASCII --temp-install=./tmp_check --top-builddir=../../..
--schedule=./parallel_schedule
============== creating temporary installation ==============
============== initializing database system ==============
pg_regress: initdb failed
Examine /home/shackle/pggit/postgresql/src/test/regress/log/initdb.log for the reason.
Command was: "/home/shackle/pggit/postgresql/src/test/regress/./tmp_check/install//home/shackle/tip/bin/initdb" -D
"/home/shackle/pggit/postgresql/src/test/regress/./tmp_check/data"-L
"/home/shackle/pggit/postgresql/src/test/regress/./tmp_check/install//home/shackle/tip/share/postgresql"--noclean >
"/home/shackle/pggit/postgresql/src/test/regress/log/initdb.log"2>&1
make[2]: *** [check] Error 2
make[2]: Leaving directory `/home/shackle/pggit/postgresql/src/test/regress'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/shackle/pggit/postgresql/src/test'
make: *** [check] Error 2
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate