Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> wrote:
> Well, looking at the callers, most if not all of them seem to actually
> pass a palloc'd copy, allocated by text_to_cstring().
>
> Should we throw a NOTICE like vanilla truncate_identifier() does?
>
> I feel it would be better to just call truncate_identifier() than roll
> your own. Assuming we want the same semantics in dblink, we'll otherwise
> have to remember to update truncate_identifier_copy() with any changes
> to truncate_identifier().
That makes sense. Now I use truncate_identifier(warn=true) for the fix.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center