Re: [PATCH] Move 'long long' check to c.h

Поиск
Список
Период
Сортировка
От Stephen Frost
Тема Re: [PATCH] Move 'long long' check to c.h
Дата
Msg-id 20100524192014.GH21875@tamriel.snowman.net
обсуждение исходный текст
Ответ на Re: [PATCH] Move 'long long' check to c.h  (Michael Meskes <meskes@postgresql.org>)
Список pgsql-hackers
* Michael Meskes (meskes@postgresql.org) wrote:
> > I think the current coding is extremely fragile (if it indeed works at
> > all) because of its assumption that <limits.h> has been included
>
> Well, this is the case in the code so far.

Right, the existing code is after limits.h is included, my suggestion to
put it in c.h would have lost limits.h and broken things.  Sorry about
that.  I didn't realize the dependency and make check didn't complain
(not that I'm sure there's even a way we could have a regression test
for this..).  I didn't intend to imply the currently-committed code
didn't work (I figured it was probably fine :), was just trying to tidy
a bit.
Thanks!
    Stephen

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Meskes
Дата:
Сообщение: Re: [PATCH] Move 'long long' check to c.h
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: pg_upgrade docs