Re: CP949 for EUC-KR?

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> wrote:

> > Should we add (or replace) CP949 for EUC-KR?
> 
> No. CP949 is not plain EUC-KR, but EUC-KR with some extensions (UHC). At
> least on CVS HEAD, we recognize CP949 as an alias for the PostgreSQL
> PG_UHC encoding.

That's it! We should have added an additional alias to chklocale, too.

Index: src/port/chklocale.c
===================================================================
--- src/port/chklocale.c    (HEAD)
+++ src/port/chklocale.c    (fixed)
@@ -172,6 +172,7 @@    {PG_GBK, "CP936"},    {PG_UHC, "UHC"},
+    {PG_UHC, "CP949"},    {PG_JOHAB, "JOHAB"},    {PG_JOHAB, "CP1361"},


Except UHC, we don't have any codepage aliases for the encodings below.
I assume we don't need to add CPxxx because Windows does not have
corresponding codepages for them, right?
   {PG_LATIN6, "ISO-8859-10"},   {PG_LATIN7, "ISO-8859-13"},   {PG_LATIN8, "ISO-8859-14"},   {PG_LATIN10,
"ISO-8859-16"},  {PG_SHIFT_JIS_2004, "SJIS_2004"},
 

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center