Core dump running PL/Perl installcheck with bleadperl [PATCH]

Поиск
Список
Период
Сортировка
От Tim Bunce
Тема Core dump running PL/Perl installcheck with bleadperl [PATCH]
Дата
Msg-id 20100305152651.GY1375@timac.local
обсуждение исходный текст
Ответы Re: Core dump running PL/Perl installcheck with bleadperl [PATCH]  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Core dump running PL/Perl installcheck with bleadperl [PATCH]  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
I encountered a core dump running PL/Perl installcheck with a very
recent git HEAD of PostgreSQL and a not quite so recent git HEAD of perl.

The cause is a subtle difference between SvTYPE(sv) == SVt_RV and
SvROK(sv). The former is checking a low-level implementation detail
while the later is directly checking "does this sv contains a reference".

The attached patch fixes the problem by changing the SvTYPE check to use
SvROK instead. Although I only tripped over one case, the patch changes
all four uses of SvTYPE(sv) == SVt_RV. The remaining uses of SvTYPE are ok.

Tim.


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: Explicit psqlrc
Следующее
От: Merlin Moncure
Дата:
Сообщение: Re: SQL compatibility reminder: MySQL vs PostgreSQL