Re: [PATCH] Provide rowcount for utility SELECTs

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [PATCH] Provide rowcount for utility SELECTs
Дата
Msg-id 20100211190408.GD3145@alvh.no-ip.org
обсуждение исходный текст
Ответ на Re: [PATCH] Provide rowcount for utility SELECTs  (Boszormenyi Zoltan <zb@cybertec.at>)
Ответы Re: [PATCH] Provide rowcount for utility SELECTs
Re: [PATCH] Provide rowcount for utility SELECTs
Список pgsql-hackers
Boszormenyi Zoltan escribió:
> Robert Haas írta:
> > ...
> > OK, please change it.
> >   
> 
> New patch is attached with the discussed changes.

This looks all wrong.  PORTAL_ONE_SELECT is now being passed through
FillPortalStore, which runs it to completion, whereas it was previously
passed via PortalRunSelect first, which has different semantics
regarding the "count" arg.

Also, even if that weren't wrong, FillPortalStore states at its header
comment that it is only used for the other two cases (ONE_RETURNING and
UTIL_SELECT), but now is being used for ONE_SELECT as well.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: [PATCH] Provide rowcount for utility SELECTs
Следующее
От: Simon Riggs
Дата:
Сообщение: Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL (which was known for a little while