Re: Miscellaneous changes to plperl [PATCH]

Поиск
Список
Период
Сортировка
От Tim Bunce
Тема Re: Miscellaneous changes to plperl [PATCH]
Дата
Msg-id 20100125160320.GB78082@timac.local
обсуждение исходный текст
Ответ на Re: Miscellaneous changes to plperl [PATCH]  (Alex Hunsaker <badalex@gmail.com>)
Ответы Re: Miscellaneous changes to plperl [PATCH]
Список pgsql-hackers
On Sat, Jan 23, 2010 at 06:40:03PM -0700, Alex Hunsaker wrote:
> On Sat, Jan 23, 2010 at 16:16, Tim Bunce <Tim.Bunce@pobox.com> wrote:
> > On Fri, Jan 22, 2010 at 08:59:10PM -0700, Alex Hunsaker wrote:
> >> On Thu, Jan 14, 2010 at 09:07, Tim Bunce <Tim.Bunce@pobox.com> wrote:
> >> I'd vote for use warnings; as well.
> >
> > I would to, but sadly it's not that simple.
> >
> > warnings uses Carp and Carp uses eval { ... } and, owing to a sad bug in
> > perl < 5.11.4, Safe can't distinguish between eval "..." and eval {...}
> > http://rt.perl.org/rt3/Ticket/Display.html?id=70970
> > So trying to load warnings fails (at least for some versions of perl).
> 
> Well that stinks.

Yeap. I was amazed that no one had run into it before.

> > I have a version of my final "Package namespace and Safe init cleanup
> > for plperl" that works around that. I opted to post a less potentially
> > controversial version of that patch in the end. If you think allowing
> > plperl code to 'use warnings;' is important (and I'd tend to agree)
> > then I'll update that final patch.
> 
> Sounds good.

FYI I've an updated patch ready but I'll wait till the commitfest has
got 'closer' as there's a fair chance a further update will be needed
anyway to make a patch that applies cleanly.

Tim.


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns
Следующее
От: "Alastair \"Bell\" Turner"
Дата:
Сообщение: Re: MySQL-ism help patch for psql