Re: patch to implement ECPG side tracing / tracking ...

Поиск
Список
Период
Сортировка
От Michael Meskes
Тема Re: patch to implement ECPG side tracing / tracking ...
Дата
Msg-id 20100113133807.GA31808@feivel.credativ.lan
обсуждение исходный текст
Ответ на patch to implement ECPG side tracing / tracking ...  (Hans-Jürgen Schönig <hs@cybertec.at>)
Ответы Re: patch to implement ECPG side tracing / tracking ...  (Hans-Juergen Schoenig <hs@cybertec.at>)
Список pgsql-hackers
Hans,

nce Jaime already asked for a use case, just a few small comments from
me.

> @@ -4,6 +4,7 @@
>  #include "postgres_fe.h"
>
>  #include <ctype.h>
> +#include <inttypes.h>

This is not portable. You don't want to include this header.

Did I see this right that you use the statement cache for auto-prepared
statements even if the statement is not auto prepared? Some statements are not
profiled, how did you decide which one to do? 

There is no test case.

Before looking into it in detail I think we should first figure out if this
feature really has a benefit.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org
VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Hitoshi Harada
Дата:
Сообщение: Re: More frame options in window functions
Следующее
От: Michael Meskes
Дата:
Сообщение: Re: ECPG patch causes warning