Re: Initial refactoring of plperl.c - updated

Поиск
Список
Период
Сортировка
От Tim Bunce
Тема Re: Initial refactoring of plperl.c - updated
Дата
Msg-id 20100110122932.GG2481@timac.local
обсуждение исходный текст
Ответ на Re: Initial refactoring of plperl.c - updated  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Initial refactoring of plperl.c - updated  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Sun, Jan 10, 2010 at 01:16:13AM -0500, Tom Lane wrote:
> Tim Bunce <Tim.Bunce@pobox.com> writes:
> > On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
> >> What's the reason for the temp file here?
>
> > Defensive. If the text2macro.pl program fails/dies then you'd be left
> > with a broken output file with a newer timestamp, so the next make
> > wouldn't rerun text2macro.pl.
>
> Doesn't make forcibly remove the target file if the command fails?
>
> [ rummages in manual... ]  It does if you specify .DELETE_ON_ERROR,
> which we do (in Makefile.global); so this bit of complication is
> a waste.

Okay.

Andrew, perhaps you could apply the attached to fix that.  (Or I could
bundle it into one of the split out plperl feature patches.)

Tim.


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: ECPG patch causes warning
Следующее
От: James Mansion
Дата:
Сообщение: Re: win32 socket definition