Re: pg_migrator issues

Alvaro Herrera wrote:
> Bruce Momjian escribi?:
>
> > > Oh, interesting about pg_dump.  Let's just go with --analyze-only.
> > > --only-analyze is feeling odd to me too.
> >
> > Done, attached and applied.
>
> <bikeshedding>
> Why -o and not, say, -Z?  I imagine you picked -o for "only" but it
> seems strange.
> </>

Hmmm, sure -Z makes sense.  Change applied with attached patch. Thanks.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: doc/src/sgml/ref/vacuumdb.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/vacuumdb.sgml,v
retrieving revision 1.48
diff -c -c -r1.48 vacuumdb.sgml
*** doc/src/sgml/ref/vacuumdb.sgml    7 Jan 2010 12:38:55 -0000    1.48
--- doc/src/sgml/ref/vacuumdb.sgml    7 Jan 2010 14:34:39 -0000
***************
*** 28,34 ****
     <group><arg>--freeze</arg><arg>-F</arg></group>
     <group><arg>--verbose</arg><arg>-v</arg></group>
     <group><arg>--analyze</arg><arg>-z</arg></group>
!    <group><arg>--analyze-only</arg><arg>-o</arg></group>
     <arg>--table | -t <replaceable>table</replaceable>
      <arg>( <replaceable class="parameter">column</replaceable> [,...] )</arg>
     </arg>
--- 28,34 ----
     <group><arg>--freeze</arg><arg>-F</arg></group>
     <group><arg>--verbose</arg><arg>-v</arg></group>
     <group><arg>--analyze</arg><arg>-z</arg></group>
!    <group><arg>--analyze-only</arg><arg>-Z</arg></group>
     <arg>--table | -t <replaceable>table</replaceable>
      <arg>( <replaceable class="parameter">column</replaceable> [,...] )</arg>
     </arg>
***************
*** 42,48 ****
     <group><arg>--freeze</arg><arg>-F</arg></group>
     <group><arg>--verbose</arg><arg>-v</arg></group>
     <group><arg>--analyze</arg><arg>-z</arg></group>
!    <group><arg>--analyze-only</arg><arg>-o</arg></group>
    </cmdsynopsis>
   </refsynopsisdiv>

--- 42,48 ----
     <group><arg>--freeze</arg><arg>-F</arg></group>
     <group><arg>--verbose</arg><arg>-v</arg></group>
     <group><arg>--analyze</arg><arg>-z</arg></group>
!    <group><arg>--analyze-only</arg><arg>-Z</arg></group>
    </cmdsynopsis>
   </refsynopsisdiv>

***************
*** 142,148 ****
       </varlistentry>

       <varlistentry>
!       <term><option>-o</option></term>
        <term><option>--analyze-only</option></term>
        <listitem>
         <para>
--- 142,148 ----
       </varlistentry>

       <varlistentry>
!       <term><option>-Z</option></term>
        <term><option>--analyze-only</option></term>
        <listitem>
         <para>
Index: src/bin/scripts/vacuumdb.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/scripts/vacuumdb.c,v
retrieving revision 1.32
diff -c -c -r1.32 vacuumdb.c
*** src/bin/scripts/vacuumdb.c    7 Jan 2010 12:38:55 -0000    1.32
--- src/bin/scripts/vacuumdb.c    7 Jan 2010 14:34:44 -0000
***************
*** 41,47 ****
          {"quiet", no_argument, NULL, 'q'},
          {"dbname", required_argument, NULL, 'd'},
          {"analyze", no_argument, NULL, 'z'},
!         {"analyze-only", no_argument, NULL, 'o'},
          {"freeze", no_argument, NULL, 'F'},
          {"all", no_argument, NULL, 'a'},
          {"table", required_argument, NULL, 't'},
--- 41,47 ----
          {"quiet", no_argument, NULL, 'q'},
          {"dbname", required_argument, NULL, 'd'},
          {"analyze", no_argument, NULL, 'z'},
!         {"analyze-only", no_argument, NULL, 'Z'},
          {"freeze", no_argument, NULL, 'F'},
          {"all", no_argument, NULL, 'a'},
          {"table", required_argument, NULL, 't'},
***************
*** 107,113 ****
              case 'z':
                  and_analyze = true;
                  break;
!             case 'o':
                  analyze_only = true;
                  break;
              case 'F':
--- 107,113 ----
              case 'z':
                  and_analyze = true;
                  break;
!             case 'Z':
                  analyze_only = true;
                  break;
              case 'F':
***************
*** 351,361 ****
      printf(_("  -f, --full                      do full vacuuming\n"));
      printf(_("  -F, --freeze                    freeze row transaction information\n"));
      printf(_("  -i, --inplace                   do full inplace vacuuming\n"));
-     printf(_("  -o, --analyze-only              only update optimizer hints\n"));
      printf(_("  -q, --quiet                     don't write any messages\n"));
      printf(_("  -t, --table='TABLE[(COLUMNS)]'  vacuum specific table only\n"));
      printf(_("  -v, --verbose                   write a lot of output\n"));
      printf(_("  -z, --analyze                   update optimizer hints\n"));
      printf(_("  --help                          show this help, then exit\n"));
      printf(_("  --version                       output version information, then exit\n"));
      printf(_("\nConnection options:\n"));
--- 351,361 ----
      printf(_("  -f, --full                      do full vacuuming\n"));
      printf(_("  -F, --freeze                    freeze row transaction information\n"));
      printf(_("  -i, --inplace                   do full inplace vacuuming\n"));
      printf(_("  -q, --quiet                     don't write any messages\n"));
      printf(_("  -t, --table='TABLE[(COLUMNS)]'  vacuum specific table only\n"));
      printf(_("  -v, --verbose                   write a lot of output\n"));
      printf(_("  -z, --analyze                   update optimizer hints\n"));
+     printf(_("  -Z, --analyze-only              only update optimizer hints\n"));
      printf(_("  --help                          show this help, then exit\n"));
      printf(_("  --version                       output version information, then exit\n"));
      printf(_("\nConnection options:\n"));