Re: plperl and inline functions -- first draft

On Sun, Nov 15, 2009 at 12:10:33PM +1100, Brendan Jurd wrote:
> I noticed that there was a fairly large amount of bogus/inconsistent
> whitespace in the patch, particularly in the body of
> plperl_inline_handler().  Some of the lines were indented with tabs,
> others with spaces.  You should stick with tabs.  There were also a
> lot of lines with a whole lot of trailing whitespace at the end.

Thanks -- I tend to forget whitespace :)

> In the documentation you refer to this feature as "inline functions".
> I think this might be mixing up the terminology ... although the code
> refers to "inline handlers" internally, the word "inline" doesn't
> appear in the user-facing documentation for the DO command.  Instead
> they are referred to as "anonymous code blocks".  I think it would
> improve consistency if the PL/Perl mention used the same term.

I can accept that argument. The attached patch modifies the documentation, and
fixes another inconsistency I found.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com