Tsutomu Yamada wrote:
> This patch using VirtualAlloc()/VirtualFree() to avoid failing in
> reattach to shared memory.
>
> Can this be added to CommitFest ?
Since this fixes a very annoying bug present in older versions, I think
this should be backpatched all the way back to 8.2.
Some notes about the patch itself:
- please use ereport() instead of elog() for error messages
- Are you really putting the pgwin32_ReserveSharedMemory declaration
inside a function? Please move that into the appropriate header file.
- Failure to reserve memory in pgwin32_ReserveSharedMemory should be a
FATAL error I think, not simply LOG.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.