Tom Lane escribió:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > This patch seems to be the right cure. (Some other users of
> > opt_definition remain; I think it's just CREATE FUNCTION by now).
>
> Surely this will break other things. I find myself wondering why you
> invented ReloptElem at all, instead of adding a field to DefElem.
I had to, precisely because it messes up other uses of DefElem ...
For example, the grammar would allow
CREATE FUNCTION ... WITH something.name = value
which we certainly don't want.
I don't expect to break anything else actually. Keep in mind that those
"opt_definition" were there precisely to carry reloptions for the
affected indexes.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.