Peter Eisentraut <peter_e@gmx.net> wrote:
> ITAGAKI Takahiro wrote:
> > Here is a patch to allow 'on' and 'off' as input texts for boolean.
>
> Regarding your FIXME comment, I think parse_bool* should be in bool.c
> and declared in builtins.h, which guc.c already includes.
> (Conceptually, the valid format of a bool should be drived by the
> boolean type, not the GUC system, I think.)
Here is an updated patch to move parse_bool* into bool.c.
I also added tests of on/off values to the regression test.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center