Re: version() output vs. 32/64 bits

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: version() output vs. 32/64 bits
Дата
Msg-id 200901060306.n0636lU14370@momjian.us
обсуждение исходный текст
Ответ на Re: version() output vs. 32/64 bits  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: version() output vs. 32/64 bits  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > So what do we want to do for 8.4?  Add 32/64-bit version() indicator and
> > add OUT parameters to the TODO list?
>
> +1.  There seems a good case for making the 32/64bit distinction
> visible somewhere, and the text version string is as good as anyplace.

OK, done with the attached patch, and autoconf run.  Magnus, would you
add this change to the MSVC build?  Thanks.

  test=> select version();
                                 version
  --------------------------------------------------------------------------

   PostgreSQL 8.4devel on i386-pc-bsdi4.3.1, compiled by GCC 2.95.3, 32-bit
  (1 row)

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: src/backend/access/common/reloptions.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/access/common/reloptions.c,v
retrieving revision 1.13
diff -c -c -r1.13 reloptions.c
*** src/backend/access/common/reloptions.c    5 Jan 2009 17:14:28 -0000    1.13
--- src/backend/access/common/reloptions.c    6 Jan 2009 02:35:32 -0000
***************
*** 667,673 ****
  {
      char       *value;
      int            value_len;
!     bool        parsed;
      bool        nofree = false;

      if (option->isset && validate)
--- 667,673 ----
  {
      char       *value;
      int            value_len;
!     bool        parsed = true;  /* quiet compiler */
      bool        nofree = false;

      if (option->isset && validate)

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tatsuo Ishii
Дата:
Сообщение: contrib Japanese README
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: Fix for compiler warning in reloptions.c