Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

Поиск
Список
Период
Сортировка
От Nikolay Shaplov
Тема Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions
Дата
Msg-id 20087087.dtqIWialUB@x200m
обсуждение исходный текст
Ответ на Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions  (vignesh C <vignesh21@gmail.com>)
Список pgsql-hackers
В письме от среда, 14 июля 2021 г. 15:09:12 MSK пользователь vignesh C
написал:
> The patch does not apply on Head anymore, could you rebase and post a
> patch. I'm changing the status to "Waiting for Author".

Thank you for notification.

I've tried to rebase it and found out that some options have been added to
partitioned table.
Handling this needs careful approach, and I will fix it two weeks later, when I
am back from vacations.


Meanwhile I would strongly suggest to change

{"vacuum_index_cleanup", RELOPT_TYPE_BOOL,

to

{"vacuum_index_cleanup", RELOPT_TYPE_ENUM,

in src/backend/access/common/reloptions.c

This change should be done in 3499df0d
But current implementation of reloptions is very error prone , and it is very
easy to miss this part.



--
Nikolay Shaplov
dhyan@nataraj.su (e-mail, jabber)
@dhyan:nataraj.su (matrix)





В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Smith
Дата:
Сообщение: Re: logical replication empty transactions
Следующее
От: Peifeng Qiu
Дата:
Сообщение: Re: Kerberos delegation support in libpq and postgres_fdw