Re: encoding cleanups in cvs repo

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: encoding cleanups in cvs repo
Дата
Msg-id 20081223152740.GD6217@alvh.no-ip.org
обсуждение исходный текст
Ответ на Re: encoding cleanups in cvs repo  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Tom Lane wrote:
> >> Out of curiosity ... what problems exactly?  I just looked through my
> >> last complete dump of CVS log history and didn't see anything funny
> >> in the messages for exc.c ...
> 
> > It's rev 1.7 of that file -- it had a ^E and a ^L.
> 
> Ah, I was looking for high-bit-set characters.

Right, we have our share of those too, but Magnus is filtering them with
iconv or Python internal recoding routines, and they don't cause
problems.  However those routines were not touching those control chars,
and later steps of the process were choking on them.

> Yeah, I see those.  The backtick is clearly the right thing if you
> compare to the adjacent commit message for another branch.

Right, and it's the usual quoting rule used by FSF stuff (and others I
assume).

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Robert Haas"
Дата:
Сообщение: Re: Proposed Patch to Improve Performance of Multi-Batch Hash Join for Skewed Data Sets
Следующее
От: Simon Riggs
Дата:
Сообщение: Re: Sync Rep: First Thoughts on Code