Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros
Дата
Msg-id 20081020212322.GG4116@alvh.no-ip.org
обсуждение исходный текст
Ответы Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros  ("Jonah H. Harris" <jonah.harris@gmail.com>)
Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения 
Alvaro Herrera wrote:
> Log Message:
> -----------
> Properly access a buffer's LSN using existing access macros instead of abusing
> knowledge of page layout.

Hmm, I just noticed this comment in bufpage.h (which was also in Jonah's
patch) :-(

typedef struct PageHeaderData
{   /* XXX LSN is member of *any* block, not only page-organized ones */   ...


So I'm now wondering if the above patch is really correct.  It'll of
course work, but is it appropriate?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Re: [GENERAL] Hot Standby utility and administrator functions
Следующее
От: "Jonah H. Harris"
Дата:
Сообщение: Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros