Re: NDirectFileRead and Write

Поиск
Список
Период
Сортировка
Искать
От
ITAGAKI Takahiro
Тема
Re: NDirectFileRead and Write
Дата
Msg-id
20080916104812.7E68.52131E4D@oss.ntt.co.jp
Ответ на
Re: NDirectFileRead and Write (ITAGAKI Takahiro)
Список
Дерево обсуждения
NDirectFileRead and Write ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Re: NDirectFileRead and Write ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Re: NDirectFileRead and Write Tom Lane <tgl@sss.pgh.pa.us>
Re: NDirectFileRead and Write ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Re: NDirectFileRead and Write ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Re: NDirectFileRead and Write Tom Lane <tgl@sss.pgh.pa.us>
Re: NDirectFileRead and Write Tom Lane <tgl@sss.pgh.pa.us>
Re: NDirectFileRead and Write Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Re: NDirectFileRead and Write "Hitoshi Harada" <umi.tanuki@gmail.com>
Re: NDirectFileRead and Write ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> 
Here is a revised patch to renewal NDirectFileRead/Write.

> Tom Lane  wrote:
> > * Let's rename them BufFileReadCount and BufFileWriteCount to reflect
> > their actual purpose.
> > * In any case I agree that the current arrangement
> > with execdebug.h declaring variables defined in bufmgr.c is just weird.

- NDirectFile{Read|Write} are renamed to BufFile{Read|Write}Count.
- They are still declared in execdebug.h and buffile.c includes it.


I did not touch messages in ShowBufferUsage() in the patch.
I think it still has meaning because BufFile counters are
kinds of direct block access.

> ShowBufferUsage()
> !   Shared blocks: ...
> !   Local  blocks: ...
> !   Direct blocks:  read,  written

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
В списке pgsql-hackers по дате отправления
Предыдущее
От: KaiGai Kohei
Дата:
Следующее
От: Tom Lane
Дата:
FAQ