Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Дата
Msg-id 20080428162702.GC5761@alvh.no-ip.org
обсуждение исходный текст
Ответ на Removing typename from A_Const (was: Empty arrays with ARRAY[])  ("Brendan Jurd" <direvus@gmail.com>)
Ответы Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Brendan Jurd escribió:

> Here's my attempt to remove the typename field from A_Const.  There
> were a few places (notably flatten_set_variable_args() in guc.c, and
> typenameTypeMod() in parse_type.c) where the code expected to see an
> A_Const with a typename, and I had to adjust for an A_Const within a
> TypeCast.  Nonetheless, there was an overall net reduction of 34 lines
> of code, so I think this was a win.

Do say ... why don't we do away with A_Const altogether and just replace
it with Value?  After this patch, I don't see what's the difference.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Recent buildfarm failures involving statement_timeout
Следующее
От: Chris Browne
Дата:
Сообщение: Re: we don't have a bugzilla