Re: Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer
Дата
Msg-id 200803181923.40492.peter_e@gmx.net
обсуждение исходный текст
Ответ на Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer  (Bruce Momjian <bruce@momjian.us>)
Ответы Re: Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Re: [COMMITTERS] pgsql: Don't need -Wno-error anymore, because flex is no longer  (Kurt Roeckx <kurt@roeckx.be>)
Список pgsql-hackers
Am Dienstag, 18. März 2008 schrieb Bruce Momjian:
> Peter Eisentraut wrote:
> > Log Message:
> > -----------
> > Don't need -Wno-error anymore, because flex is no longer producing
> > warnings.
>
> I see this patch only affects ecpg?  Is this related to Tom's report
> from trying the new flex?

Yes.  There used to be a few -Wno-error uses throughout the source code, near 
the flex calls, to work around the well-known flex warnings issue in case 
someone wanted to use -Werror to check his builds.  The fact that there was 
only one such use left in the ecpg subtree shows that this wasn't really 
maintained and could never have worked reliably.

> Are we assuming that all CVS build people 
> also have the new flex?  Is the new flex even installed on the server
> that makes our tarballs?  Are we all supposed to use the new flex?

I think it is reasonable to assume that those wanting to use -Werror should 
use the new flex, because if they don't the build will fail anyway, at any of 
the other lexers.


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: whaddya know, a build with no flex noise at all
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: Proposal for Null Bitmap Optimization(for Trailing NULLs)