sinval.c / sinvaladt.c restructuring
От
Alvaro Herrera
Тема
sinval.c / sinvaladt.c restructuring
Дата
Msg-id
20080229193955.GM4673@alvh.no-ip.org
Список
Дерево обсуждения
sinval.c / sinvaladt.c restructuring Alvaro Herrera <alvherre@commandprompt.com>
Re: sinval.c / sinvaladt.c restructuring Bruce Momjian <bruce@momjian.us>
Re: sinval.c / sinvaladt.c restructuring Tom Lane <tgl@sss.pgh.pa.us>
I just modified the interactions in sinval.c and sinvaladt.c per http://thread.gmane.org/gmane.comp.db.postgresql.devel.patches/18820/focus=18822 It looks a lot saner this way: the code that actually deals with the queue, including locking etc, is all in sinvaladt.c. This means that the struct definition of the queue, and the queue pointer, are now internal "implementation details" inside sinvaladt.c. One side effect of this change is that the call to SendPostmasterSignal now occurs after the lock has been released. ISTM this is a good idea on general principles (no syscalls in lwlocked code), but I'm wondering if I created a thundering hoard problem that did not exist before. All tests pass. As a test of Review Board, I uploaded the patch to it: http://reviewdemo.postgresql.org/r/19/ -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.
В списке pgsql-patches по дате отправления