Re: pgsql: Sync our regex code with upstream changes since last time we did

Alvaro Herrera wrote:
> Andrew Dunstan wrote:
> >
> >
> > Tom Lane wrote:
> >> Note that I didn't make any effort to duplicate a lot of cosmetic changes
> >> that they made to bring their copy into line with their own style
> >> guidelines, such as adding braces around single-line IF bodies.  Most of
> >> those we either had done already (such as ANSI-fication of function headers)
> >> or there is no point because pgindent would undo the change anyway.
> >
> > Not objecting, but IIRC we disabled the pgindent code that removes
> > braces around single line (or rather statement) IF bodies several years
> > ago.
>
> Yeah, we did, because it was removing the braces around PG_TRY()
> constructs.

We removed it because people didn't like changes to cases like:

    if ()
    {
        a;
    }
    else
    {
        b;
    }

I don't remember an issue with PG_TRY, which I could have fixed.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +