Re: pgindent issue with EXEC_BACKEND-only typedefs
От
Bruce Momjian
Тема
Re: pgindent issue with EXEC_BACKEND-only typedefs
Дата
Msg-id
200712161000.lBGA0Yq02098@momjian.us
Ответ на
pgindent issue with EXEC_BACKEND-only typedefs (Alvaro Herrera)
Список
Дерево обсуждения
pgindent issue with EXEC_BACKEND-only typedefs Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: pgindent issue with EXEC_BACKEND-only typedefs Bruce Momjian <bruce@momjian.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Tom Lane <tgl@sss.pgh.pa.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Bruce Momjian <bruce@momjian.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Alvaro Herrera <alvherre@commandprompt.com>
Re: pgindent issue with EXEC_BACKEND-only typedefs Bruce Momjian <bruce@momjian.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Bruce Momjian <bruce@momjian.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Bruce Momjian <bruce@momjian.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Tom Lane <tgl@sss.pgh.pa.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Alvaro Herrera <alvherre@commandprompt.com>
Re: pgindent issue with EXEC_BACKEND-only typedefs Bruce Momjian <bruce@momjian.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Tom Lane <tgl@sss.pgh.pa.us>
Re: pgindent issue with EXEC_BACKEND-only typedefs Bruce Momjian <bruce@momjian.us>
Alvaro Herrera wrote: > Hi, > > It seems pgindent is not considering EXEC_BACKEND typedefs. For > example, > > static void restore_backend_variables(BackendParameters * param, Port *port); > > BackendParameters is not considered a typedef. > > Not sure how serious an issue this is ... I just noticed and thought I > would mention it. Yep. The cause is that find_typedefs actually pulls the typedef out of the debugged-enabled binary, and on Unix those functions aren't used by default. This is spelled out in the pgindent/README in CVS. I could just EXEC_BACKEND in the debug build I use but I suppose there are other typedef I am missing as well. Any idea on a more comprehensive solution to finding typedefs? -- Bruce Momjian http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
В списке pgsql-hackers по дате отправления