Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link
Дата
Msg-id 200711131815.lADIFrD29372@momjian.us
обсуждение исходный текст
Ответ на Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link
Список pgsql-committers
Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > Am Samstag, 10. November 2007 schrieb Bruce Momjian:
> >> Use strip -x on OS/X-darwin because non-"-x" causes link problems:
>
> > How will this work, considering that $template isn't set anywhere?
>
> It won't, of course.  Perhaps something like
>
>     if test `uname -s` = Darwin
>
> instead.

I am afraid some unames don't have -s, so I did uname -a and tested for
it starting with Darwin.  Patch attached and applied.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: config/install-sh
===================================================================
RCS file: /cvsroot/pgsql/config/install-sh,v
retrieving revision 1.5
diff -c -c -r1.5 install-sh
*** config/install-sh    10 Nov 2007 16:15:23 -0000    1.5
--- config/install-sh    13 Nov 2007 18:14:11 -0000
***************
*** 59,65 ****
  # Darwin normal strip removes symbols from shared libraries
  # that are later needed for dynamic linking, so use strip -x.
  # http://archives.postgresql.org/pgsql-hackers/2007-10/msg01470.php
! if test "$template" = "darwin"
  then    stripprog="${STRIPPROG-strip -x}"
  else    stripprog="${STRIPPROG-strip}"
  fi
--- 59,65 ----
  # Darwin normal strip removes symbols from shared libraries
  # that are later needed for dynamic linking, so use strip -x.
  # http://archives.postgresql.org/pgsql-hackers/2007-10/msg01470.php
! if test expr "`uname -a`" : 'Darwin' -ne 0
  then    stripprog="${STRIPPROG-strip -x}"
  else    stripprog="${STRIPPROG-strip}"
  fi

В списке pgsql-committers по дате отправления:

Предыдущее
От: momjian@postgresql.org (Bruce Momjian)
Дата:
Сообщение: pgsql: Modify OS/X Darin test to actually work, (no $template)
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link