Re: OpenSSL Applink

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: OpenSSL Applink
Дата
Msg-id 200709290843370000@02967250
обсуждение исходный текст
Ответ на OpenSSL Applink  (Dave Page <dpage@postgresql.org>)
Ответы Re: OpenSSL Applink  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches

> ------- Original Message -------
> From: Tom Lane <tgl@sss.pgh.pa.us>
> To: Dave Page <dpage@postgresql.org>
> Sent: 29/09/07, 01:28:09
> Subject: Re: [PATCHES] OpenSSL Applink
>
> I concur with Magnus that it'll be better if there's not two code paths
> here.  It's not entirely clear whether BIO_new_fp() would avoid the
> problematic calls, but it doesn't look like it'd be hard to try.

The last version of the patch I posted uses BIO_new_file() in all cases, and (from memory) BIO_get_fp() in the
non-win32case to get a FILE* to pass to fstat. 

I believe the problem is sharing FILE*'s between differing runtime versions used by openssl and the app. Coding it with
BIO_new_filemakes it less tempting for future changes to start mucking about with FILE*'s on Windows. 

Note that I've been away from my *nix boxes so I haven't tested the patch except on Windows yet.

/D

В списке pgsql-patches по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: Add chklocale.c to msvc build
Следующее
От: Simon Riggs
Дата:
Сообщение: set_ps_display during recovery