Re: guc patch: Make variables fall back to default values

Поиск
Список
Период
Сортировка
От Joachim Wieland
Тема Re: guc patch: Make variables fall back to default values
Дата
Msg-id 20070313105418.GA18913@mcknight.de
обсуждение исходный текст
Ответ на Re: guc patch: Make variables fall back to default values  (Gregory Stark <stark@enterprisedb.com>)
Ответы Re: guc patch: Make variables fall back to default values  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-patches
On Tue, Mar 13, 2007 at 08:22:17AM +0000, Gregory Stark wrote:
> The code seems to assume that all custom variables are strings. There are
> about half a dozen Assert(variable->vartype == PGC_STRING) throughout the
> patch. That's not true, plperl's use_strict is a boolean and we have
> DefineCustome*Variable functions for each type of variable. Perl bombs
> because plperl.use_strict is a boolean.

The attached patch removes those Asserts.

But this is not the whole story. I wonder why setting "plperl.use_strict"
is supposed to work at all? Where is the corresponding definition of
"plperl" as a custom variable class? I can add it manually to
postgresql.conf and make the regression tests work but is this the intended
way?


Joachim


Вложения

В списке pgsql-patches по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: pgbench on mingw needs fflush
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Recalculating OldestXmin in a long-running vacuum