pgsql: Turn the rangetable used by the executor into a flat list, and
От | tgl@postgresql.org (Tom Lane) |
---|---|
Тема | pgsql: Turn the rangetable used by the executor into a flat list, and |
Дата | |
Msg-id | 20070222220026.727519FB532@postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Log Message: ----------- Turn the rangetable used by the executor into a flat list, and avoid storing useless substructure for its RangeTblEntry nodes. (I chose to keep using the same struct node type and just zero out the link fields for unneeded info, rather than making a separate ExecRangeTblEntry type --- it seemed too fragile to have two different rangetable representations.) Along the way, put subplans into a list in the toplevel PlannedStmt node, and have SubPlan nodes refer to them by list index instead of direct pointers. Vadim wanted to do that years ago, but I never understood what he was on about until now. It makes things a *whole* lot more robust, because we can stop worrying about duplicate processing of subplans during expression tree traversals. That's been a constant source of bugs, and it's finally gone. There are some consequent simplifications yet to be made, like not using a separate EState for subplans in the executor, but I'll tackle that later. Modified Files: -------------- pgsql/doc/src/sgml: indexam.sgml (r2.21 -> r2.22) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/indexam.sgml.diff?r1=2.21&r2=2.22) pgsql/src/backend/commands: explain.c (r1.156 -> r1.157) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/explain.c.diff?r1=1.156&r2=1.157) pgsql/src/backend/executor: execMain.c (r1.287 -> r1.288) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c.diff?r1=1.287&r2=1.288) execUtils.c (r1.145 -> r1.146) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execUtils.c.diff?r1=1.145&r2=1.146) nodeFunctionscan.c (r1.43 -> r1.44) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeFunctionscan.c.diff?r1=1.43&r2=1.44) nodeSubplan.c (r1.85 -> r1.86) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSubplan.c.diff?r1=1.85&r2=1.86) nodeSubqueryscan.c (r1.35 -> r1.36) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSubqueryscan.c.diff?r1=1.35&r2=1.36) nodeValuesscan.c (r1.6 -> r1.7) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeValuesscan.c.diff?r1=1.6&r2=1.7) pgsql/src/backend/nodes: copyfuncs.c (r1.367 -> r1.368) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c.diff?r1=1.367&r2=1.368) equalfuncs.c (r1.299 -> r1.300) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c.diff?r1=1.299&r2=1.300) outfuncs.c (r1.300 -> r1.301) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c.diff?r1=1.300&r2=1.301) print.c (r1.84 -> r1.85) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/print.c.diff?r1=1.84&r2=1.85) pgsql/src/backend/optimizer/path: allpaths.c (r1.160 -> r1.161) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/allpaths.c.diff?r1=1.160&r2=1.161) costsize.c (r1.177 -> r1.178) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/costsize.c.diff?r1=1.177&r2=1.178) pgsql/src/backend/optimizer/plan: createplan.c (r1.225 -> r1.226) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/createplan.c.diff?r1=1.225&r2=1.226) planagg.c (r1.28 -> r1.29) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/planagg.c.diff?r1=1.28&r2=1.29) planner.c (r1.214 -> r1.215) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/planner.c.diff?r1=1.214&r2=1.215) setrefs.c (r1.130 -> r1.131) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/setrefs.c.diff?r1=1.130&r2=1.131) subselect.c (r1.120 -> r1.121) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/subselect.c.diff?r1=1.120&r2=1.121) pgsql/src/backend/optimizer/prep: prepunion.c (r1.138 -> r1.139) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/prep/prepunion.c.diff?r1=1.138&r2=1.139) pgsql/src/backend/optimizer/util: clauses.c (r1.235 -> r1.236) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/clauses.c.diff?r1=1.235&r2=1.236) relnode.c (r1.85 -> r1.86) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/relnode.c.diff?r1=1.85&r2=1.86) pgsql/src/backend/parser: parse_expr.c (r1.211 -> r1.212) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_expr.c.diff?r1=1.211&r2=1.212) pgsql/src/backend/utils/adt: selfuncs.c (r1.226 -> r1.227) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/selfuncs.c.diff?r1=1.226&r2=1.227) pgsql/src/include/executor: executor.h (r1.137 -> r1.138) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/executor/executor.h.diff?r1=1.137&r2=1.138) pgsql/src/include/nodes: execnodes.h (r1.168 -> r1.169) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/execnodes.h.diff?r1=1.168&r2=1.169) plannodes.h (r1.91 -> r1.92) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/plannodes.h.diff?r1=1.91&r2=1.92) primnodes.h (r1.126 -> r1.127) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/primnodes.h.diff?r1=1.126&r2=1.127) print.h (r1.26 -> r1.27) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/print.h.diff?r1=1.26&r2=1.27) relation.h (r1.137 -> r1.138) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/relation.h.diff?r1=1.137&r2=1.138) pgsql/src/include/optimizer: cost.h (r1.84 -> r1.85) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/cost.h.diff?r1=1.84&r2=1.85) planmain.h (r1.99 -> r1.100) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/planmain.h.diff?r1=1.99&r2=1.100)
В списке pgsql-committers по дате отправления:
Следующее
От: tgl@postgresql.org (Tom Lane)Дата:
Сообщение: pgsql: Fix bug I introduced in recent patch to make hash joins discard