Re: pgsql: Fix for plpython functions; return true/false for boolean,

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: pgsql: Fix for plpython functions; return true/false for boolean,
Дата
Msg-id 200702200349.l1K3nR522344@momjian.us
обсуждение исходный текст
Ответ на Re: pgsql: Fix for plpython functions; return true/false for boolean,  (Guido Goldstein <guido.goldstein@a-nugget.org>)
Список pgsql-hackers
I am still waiting for a plpython patch that has Python version
checking.

---------------------------------------------------------------------------

Guido Goldstein wrote:
> Peter Eisentraut wrote:
> > Guido Goldstein wrote:
> >> Is it possible to tell me which python versions you want to
> >> support?
> > 
> > The issue isn't so much which versions we want to support.  There is 
> > certainly some flexibility with that.  But when a patch breaks the 
> > buildfarm a) unannounced and b) without any apparent feature gain, then 
> > people get annoyed.
> 
> If this breaks the buildfarm it's not my failure.
> Except you can tell me what I've got to do with the
> buildfarm.
> 
> If you mean that plpython didn't compile, fine; simply tell
> the people what version they should consider when sending
> in patches.
> 
> I've checked the patch with postgres 8.1.3 and 8.2.1
> with python 2.4 and 2.5 on intel 32 bit and amd 64 bit
> systems; all systems running linux.
> 
> *And* it's not a feature patch but a bug-fixing one!
> Python is a language with strong typing, so silently
> converting a datatype is a bug -- not a feature.
> Btw, you'll lose the type information of boolean columns in
> trigger functions (NEW and OLD dicts, no explicit parameters),
> which does cause problems.
> 
> > That said, we certainly try to support a few more versions of Python 
> [...]
> 
> If you want to support python 2.3 use the attached patch, which also
> works for the newer python versions.
> The Python 2.3 branch is the oldest _officially_ supported python version.
> 
> Anyway, to circumvent the above mentiond point a) I herewith anncounce
> that the included patch might break the buildfarm.
> 
> Cheers
>    Guido
> 


> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: New feature request: FlashBack Query
Следующее
От: Greg Smith
Дата:
Сообщение: Log levels for checkpoint/bgwriter monitoring