Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > ISTM these parts of that patch should be applied to our code:
>
> > +--- postgresql-8.1beta3-old/src/bin/pg_controldata/pg_controldata.c 2005-10-03 02:28:41.000000000 +0200
> > ++++ postgresql-8.1beta3/src/bin/pg_controldata/pg_controldata.c 2005-10-13 18:00:42.000000000 +0200
> > +@@ -73,7 +73,7 @@
> > + char *strftime_fmt = "%c";
> > + const char *progname;
> > +
> > +- set_pglocale_pgservice(argv[0], "pg_controldata");
> > ++ set_pglocale_pgservice(argv[0], "pg_controldata-8.1");
>
> Egad. What an ugly, unmaintainable crock.
Well, we could certainly not use it in the same form, but with a macro,
making it more future-proof.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.