Re: Getting a move on for 8.2 beta
| От | Peter Eisentraut |
|---|---|
| Тема | Re: Getting a move on for 8.2 beta |
| Дата | |
| Msg-id | 200609041951.22400.peter_e@gmx.net обсуждение |
| Ответ на | Re: Getting a move on for 8.2 beta (Bruce Momjian <bruce@momjian.us>) |
| Ответы |
Re: Getting a move on for 8.2 beta
guc comment changes (was Re: Getting a move on for 8.2 beta) |
| Список | pgsql-hackers |
Bruce Momjian wrote: > How many times do I have to say this: IT IS NOT A REFACTOR PATCH AS > REPORTED BY THE AUTHOR, AND PETER HAS NOT REFUTED THAT. The initial patch was the feature plus some code refactoring included. That was what the author said. I asked him to submit the refactoring and the feature as two separate patches. What I got was a refactoring subpatch that actually made the code longer in terms of lines, which must be the very first code refactoring ever to achieve that. I did not get a satisfying answer on why that has to be, so I sort of lost interest in working with that patch. That does not mean that the patch is bad, and I certainly support the feature change. But I can't efficiently review the patch. If someone else wants to do it, go ahead. -- Peter Eisentraut http://developer.postgresql.org/~petere/
В списке pgsql-hackers по дате отправления: