Am Mittwoch, 30. August 2006 18:01 schrieb Tom Lane:
> This is the first time I've actually looked at this patch, and I am
> dismayed. viewUpdate.c looks like nothing so much as a large program
> with a small program struggling to get out. What is all the stuff about
> handling multiple base rels? SQL92, at least, does not say that a join
> is updatable, and AFAICT this patch is rejecting that too ...
But later SQL versions allow some of that, so at least it shouldn't hurt to
have some parts of the code to be more general in preparation of that.
> I'm unclear as to why you've got DO INSTEAD NOTHING rules in there ---
You need to have one unconditional rule if you have a bunch of conditional
ones. The system does not see through the fact that the conditional ones
cover all cases.
> The pg_dump changes seem pretty odd too. Why wouldn't you just
> ignore implicit rules during a dump, expecting the system to
> regenerate them when the view is reloaded?
Right.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/