Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Ok, this patch implements more or less this idea; except that instead of
> > checking the list of implicit dependencies for later objects, we iterate
> > twice on the list of objects to delete, and create a list of implicit
> > dependencies on all of them the first time, and delete those not on that
> > list the second time.
>
> In the light of morning it occurs to me that probably the best code
> factoring for this is for dependency.c to export a
> performMultipleDeletions() function that takes an objectAddresses list
> of targets and does all the dependency-chasing internally. This would
> reduce the amount of cruft that has to be exported from dependency.c.
Sounds a pretty obvious move. This would be it then. Please note the
changes to the ObjectAddresses stuff, mainly to not move the definition
of struct ObjectAddresses to dependency.h but instead move only the
typedef.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.