Re: ShmemAlloc() alignment patch

On Fri, Jul 14, 2006 at 02:50:31PM +0800, Qingqing Zhou wrote:
> In ShmemAlloc() we have:
>
>   newStart = BUFFERALIGN(newStart);
>   newSpace = (void *) (ShmemBase + newStart);
>   return newSpace;
>
> Notice that though newStart is ALIGNOF_BUFFER, ShmemBase is not. Thus the
> newSpace is not aligned as we disired.

How can ShmemBase not be aligned? Surely it's page-aligned?

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.