Re: [HACKERS] BEGIN inside transaction should be an error

Gurjeet Singh wrote:

> *************** BeginTransactionBlock(void)
> *** 2725,2731 ****
>          case TBLOCK_SUBINPROGRESS:
>          case TBLOCK_ABORT:
>          case TBLOCK_SUBABORT:
> !             ereport(WARNING,
>                      (errcode(ERRCODE_ACTIVE_SQL_TRANSACTION),
>                       errmsg("there is already a
>                       transaction in progress")));
>              break;
> --- 2726,2732 ----
>          case TBLOCK_SUBINPROGRESS:
>          case TBLOCK_ABORT:
>          case TBLOCK_SUBABORT:
> !             ereport(ERROR,
>                      (errcode(ERRCODE_ACTIVE_SQL_TRANSACTION),
>                       errmsg("there is already a
>                       transaction in progress")));
>              break;

This should depend on the GUC variable for the patch to work at all ...

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support