Re: Add missing const qualifier in ECPG
От | Michael Meskes |
---|---|
Тема | Re: Add missing const qualifier in ECPG |
Дата | |
Msg-id | 20051130130124.GA20593@1 обсуждение исходный текст |
Ответ на | Add missing const qualifier in ECPG (Qingqing Zhou <zhouqq@cs.toronto.edu>) |
Список | pgsql-patches |
I just applied most of your patch to 8.0, 8.1 and HEAD. The only thing I didn't is: diff -c -r1.7 memory.c *** ecpglib/memory.c 15 Oct 2005 02:49:47 -0000 1.7 --- ecpglib/memory.c 16 Nov 2005 00:40:57 -0000 *************** *** 11,17 **** void ECPGfree(void *ptr) { ! free(ptr); } char * --- 11,18 ---- void ECPGfree(void *ptr) { ! if (ptr) ! free(ptr); } char * Is there a reason why you changed this? Acocrding to the docs free(NULL) does nothing anyway. Also you mentioned: ... seems we allow strdup() fails silently in various places. Shall we do something about it? ... Yes! Thanks for pointing this out. I already committed a patch that changes alls strdup() calls to ECPGstrdup() calls that correctly raise an error condition. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!
В списке pgsql-patches по дате отправления: