Re: pthread stack on FreeBSD WAS: HEAD doesn't cope with libraries

Patch applied.  Thanks.  If we made plpython worse, we will hear about
it soon enough.  The freebsd-specific changes seem safe, considering
they came from the FreeBSD port maintainers themselves.

---------------------------------------------------------------------------


Jim C. Nasby wrote:
> On Wed, Jul 13, 2005 at 01:24:17PM -0400, Andrew Dunstan wrote:
> > >In any case, I've cleared the conflict and I'm running a build right
> > >now.
> 
> octopus is building again, and is back to the behavior I mentioned in
> http://archives.postgresql.org/pgsql-bugs/2005-07/msg00096.php. Is this
> something that should be fixed in code? There are two patches in the
> FreeBSD ports tree for postgresql 8:
> 
> decibel@flake.2[14:18]/usr/ports/databases/postgresql80-server/files:47>cat patch-plpython-Makefile
patch-src-makefiles-Makefile.freebsd
 
> --- src/pl/plpython/Makefile.orig       Fri Nov 19 20:23:01 2004
> +++ src/pl/plpython/Makefile    Tue Dec 28 23:32:16 2004
> @@ -9,7 +9,7 @@
>  # shared library.  Since there is no official way to determine this
>  # (at least not in pre-2.3 Python), we see if there is a file that is
>  # named like a shared library.
> -ifneq (,$(wildcard $(python_libdir)/libpython*$(DLSUFFIX)*))
> +ifneq (,$(wildcard $(python_libdir)/../../libpython*$(DLSUFFIX)*))
>  shared_libpython = yes
>  endif
>  
> --- src/makefiles/Makefile.freebsd.orig Fri Nov 19 01:41:39 2004
> +++ src/makefiles/Makefile.freebsd      Tue Dec 21 02:44:09 2004
> @@ -11,7 +11,7 @@
>  ifeq ($(findstring sparc,$(host_cpu)), sparc)
>  CFLAGS_SL = -fPIC -DPIC
>  else
> -CFLAGS_SL = -fpic -DPIC
> +CFLAGS_SL = -fPIC -DPIC
>  endif
>  
>  
> @@ -29,3 +29,5 @@
>  endif
>  
>  sqlmansect = 7
> +
> +allow_nonpic_in_shlib = yes
> 
> The first of these patches makes me think that octopus might actually be
> finding the wrong library, though things are fine on platypus with
> python 2.3 (octopus is running 2.4).
> 
> I'm upgrading platypus to 2.4 right now to see what that changes, if
> anything.
> -- 
> Jim C. Nasby, Database Consultant               decibel@decibel.org 
> Give your computer some brain candy! www.distributed.net Team #1828
> 
> Windows: "Where do you want to go today?"
> Linux: "Where do you want to go tomorrow?"
> FreeBSD: "Are you guys coming, or what?"
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073