Re: pgsql: Add time/date macros for code clarity: #define

Tom Lane wrote:
> momjian@svr1.postgresql.org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Add time/date macros for code clarity:
>
> >     #define DAYS_PER_YEAR   365.25
> >     #define MONTHS_PER_YEAR 12
> >     #define DAYS_PER_MONTH  30
> >     #define HOURS_PER_DAY   24
>
> Considering that only one of these four is actually an accurate
> constant, I have to question the usefulness of this.

Yea, the problem is that these non-absolute constants are littered all
through the code, so it is best to have them at least in one place.  I
will add a comment marking the non-accurate ones more clearly.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073