Author: dpage
Date: 2005-06-07 13:49:53 +0100 (Tue, 07 Jun 2005)
New Revision: 4282
Modified:
trunk/pgadmin3/TODO.txt
trunk/pgadmin3/src/dlg/dlgFunction.cpp
Log:
Minor stored proc related fix.
Todo updates.
Modified: trunk/pgadmin3/TODO.txt
===================================================================
--- trunk/pgadmin3/TODO.txt 2005-06-06 16:05:25 UTC (rev 4281)
+++ trunk/pgadmin3/TODO.txt 2005-06-07 12:49:53 UTC (rev 4282)
@@ -11,13 +11,12 @@
<li>Refactoring
<ul>
<li>rewrite cast, operator, operatorclass to use pgDatatype
+ <li>rewrite ctlSQLResult as virtual wxListView
</ul>
<li>Enhancements / wishes
<ul>
- <li>Add support for named parameters in functions
<li>Guru hint for long query retrieval durations
- <li>rewrite ctlSQLResult as virtual wxListView
<li>Track connection usage by property dialogs to prevent closing used connections
<li>Allow Sequence to be attached to existing int4/int8 columns
<li>Display column comments in table definition
@@ -41,7 +40,6 @@
<li>CREATE TABLE LIKE table
<li>Operator class property: to implement
<li>List column defaults on views.
- <li>Generate PostgreSQL document indexes using docbook (<a
href="http://docbook.sourceforge.net/release/xsl/current/doc/htmlhelp.html">http://docbook.sourceforge.net/release/xsl/current/doc/htmlhelp.html</a>).
<li>find solution for dlgProperty::AppendQuoted if schemaname has a dot
<li>Add code completion to the SQL editor.
<li>Allow EditGrid to use comboboxes filled from FK tables.
@@ -54,12 +52,6 @@
<li>Index Checker. A tool to check for missing indexes on FK columns.
<li>pl/pgsql debugger.
</ul>
-
- <li>Controversial :-)
- <ul>
- <li>Cursor based query tool.<br>
- * Remark (AP): considered this to be implemented external to pgAdmin3
- </ul>
</ul>
Modified: trunk/pgadmin3/src/dlg/dlgFunction.cpp
===================================================================
--- trunk/pgadmin3/src/dlg/dlgFunction.cpp 2005-06-06 16:05:25 UTC (rev 4281)
+++ trunk/pgadmin3/src/dlg/dlgFunction.cpp 2005-06-07 12:49:53 UTC (rev 4282)
@@ -524,11 +524,20 @@
if (quoted)
{
wxString colName = lstArguments->GetText(i);
- int i=GetDirection(colName);
- wxString dir=rdbDirection->GetString(i);
- colName = colName.Mid(dir.Length()+1);
+ if (isProcedure)
+ {
+ int i=GetDirection(colName);
+ wxString dir=rdbDirection->GetString(i);
+ colName = colName.Mid(dir.Length());
- args += dir + wxT(" ") + qtIdent(colName) + wxT(" ");
+ args += dir + qtIdent(colName) + wxT(" ");
+ }
+ else
+ {
+ args += qtIdent(colName) + wxT(" ");
+ }
+
+
}
else
args += lstArguments->GetText(i) + wxT(" ");