Re: transformExpr() refactor

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: transformExpr() refactor
Дата
Msg-id 200411020416.iA24Gnv06545@candle.pha.pa.us
обсуждение исходный текст
Ответ на Re: transformExpr() refactor  (James William Pye <flaw@rhid.com>)
Список pgsql-patches
James William Pye wrote:
-- Start of PGP signed section.
> On Thu, 2004-10-28 at 18:00, Neil Conway wrote:
> > I think the code is more readable this way.
>
> FWIW, I'm +1 on the patch for the above reason.

I liked the large case statement myself.  I don't like breaking things
into pieces when the pieces are just splits out of a switch structure.
You are basically giving names to switch actions and pushing into
functions with names.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

В списке pgsql-patches по дате отправления:

Предыдущее
От: James William Pye
Дата:
Сообщение: Re: transformExpr() refactor
Следующее
От: Kris Jurka
Дата:
Сообщение: pthread.h header check