Re: logging enhancements, minor code cleanup

Andrew Dunstan wrote:
>
> Answer = sane == 'fill buffer, don't overfill buffer' ? 'yes' : 'no';
>
> :-)
>
> Seriously, I will add comments when I submit the revised patch to
> demonstrate the loop invariants etc. so nobody need get worried when
> reading the code.
>
> As for session end logging, I'm leaning in favor of a new
> log_session_end or log_connection_end boolean, so that there is minimal
> backwards compatibility impact. (Interestingly, that is actually the
> only part of this stuff that is of any use to me right now).

Agreed.  A separate boolean is more self-documenting than 0/1/2.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073