Re: anonymous composite types for Table Functions (aka SRFs)

Woh, again, I have another compile error:

    equalfuncs.c: In function `_equalRangeVar':
    equalfuncs.c:1610: structure has no member named `coldeflist'
    equalfuncs.c:1610: structure has no member named `coldeflist'
    gmake[2]: *** [equalfuncs.o] Error 1

Again, a patch is attached that clearly needs fixing.  I should have
tested this more, but I am heading out now and wanted to get it in
before more code drifted.

---------------------------------------------------------------------------

Bruce Momjian wrote:
>
> Woh, seems like there is a compile problem.  Joe, my guess is that the
> pg_proc patch you send me today didn't have _all_ of the needed changes.
>
> I am attaching a patch with the fix need to get it to compile, but it is
> clearly wrong.  Would you submit a fix based on current CVS for this?  I
> know this gets confusing when patches conflict.
>
>
> ---------------------------------------------------------------------------
>
> Bruce Momjian wrote:
> >
> > [ New version of pg_proc.c used for application.]
> >
> > Patch applied.  Thanks.  initdb forced.
> >

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: src/backend/catalog/pg_proc.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/backend/catalog/pg_proc.c,v
retrieving revision 1.83
diff -c -r1.83 pg_proc.c
*** src/backend/catalog/pg_proc.c    4 Aug 2002 19:48:09 -0000    1.83
--- src/backend/catalog/pg_proc.c    4 Aug 2002 19:58:03 -0000
***************
*** 318,324 ****
   * type he claims.
   */
  static void
! checkretval(Oid rettype, List *queryTreeList)
  {
      Query       *parse;
      int            cmd;
--- 318,324 ----
   * type he claims.
   */
  static void
! checkretval(Oid rettype, char fn_typtype /* XXX FIX ME */, List *queryTreeList)
  {
      Query       *parse;
      int            cmd;
Index: src/backend/nodes/equalfuncs.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/backend/nodes/equalfuncs.c,v
retrieving revision 1.147
diff -c -r1.147 equalfuncs.c
*** src/backend/nodes/equalfuncs.c    4 Aug 2002 19:48:09 -0000    1.147
--- src/backend/nodes/equalfuncs.c    4 Aug 2002 19:58:03 -0000
***************
*** 1607,1615 ****
          return false;
      if (!equal(a->alias, b->alias))
          return false;
      if (!equal(a->coldeflist, b->coldeflist))
          return false;
!
      return true;
  }

--- 1607,1616 ----
          return false;
      if (!equal(a->alias, b->alias))
          return false;
+ /* FIX ME XXX
      if (!equal(a->coldeflist, b->coldeflist))
          return false;
! */
      return true;
  }