Re: FUNC_MAX_ARGS benchmarks

OK, time to get moving folks.  Looks like the increase in the function
args to 32 and the NAMEDATALEN to 128 has been sufficiently tested.  Tom
has some ideas on removing some memset() calls for function args to
speed things up, but we don't have to wait for that go get going.  The
end of August is nearing.

Is there any reason to delay the change further?

---------------------------------------------------------------------------

Joe Conway wrote:
> Tom Lane wrote:
> > Did you happen to make any notes about the disk space occupied by the
> > database?  One thing I was worried about was the bloat that'd occur
> > in pg_proc, pg_index, and pg_proc_proname_args_nsp_index.  Aside from
> > costing disk space, this would indirectly slow things down due to more
> > I/O to read these tables --- an effect that probably your test couldn't
> > measure, since it wasn't touching very many entries in any of those
> > tables.
> 
> #define INDEX_MAX_KEYS        16
> #define FUNC_MAX_ARGS        INDEX_MAX_KEYS
> du -h --max-depth=1 /opt/data/pgsql/data/base/
> 2.7M    /opt/data/pgsql/data/base/1
> 2.7M    /opt/data/pgsql/data/base/16862
> 2.7M    /opt/data/pgsql/data/base/16863
> 2.7M    /opt/data/pgsql/data/base/16864
> 3.2M    /opt/data/pgsql/data/base/16865
> 2.7M    /opt/data/pgsql/data/base/16866
> 17M     /opt/data/pgsql/data/base
> 
> #define INDEX_MAX_KEYS        32
> #define FUNC_MAX_ARGS        INDEX_MAX_KEYS
>   du -h --max-depth=1 /opt/data/pgsql/data/base/
> 3.1M    /opt/data/pgsql/data/base/1
> 3.1M    /opt/data/pgsql/data/base/16862
> 3.1M    /opt/data/pgsql/data/base/16863
> 3.1M    /opt/data/pgsql/data/base/16864
> 3.6M    /opt/data/pgsql/data/base/16865
> 3.1M    /opt/data/pgsql/data/base/16866
> 19M     /opt/data/pgsql/data/base
> 
> #define INDEX_MAX_KEYS        64
> #define FUNC_MAX_ARGS        INDEX_MAX_KEYS
> du -h --max-depth=1 /opt/data/pgsql/data/base/
> 3.9M    /opt/data/pgsql/data/base/1
> 3.9M    /opt/data/pgsql/data/base/16862
> 3.9M    /opt/data/pgsql/data/base/16863
> 3.9M    /opt/data/pgsql/data/base/16864
> 4.4M    /opt/data/pgsql/data/base/16865
> 3.9M    /opt/data/pgsql/data/base/16866
> 24M     /opt/data/pgsql/data/base
> 
> #define INDEX_MAX_KEYS        128
> #define FUNC_MAX_ARGS        INDEX_MAX_KEYS
> du -h --max-depth=1 /opt/data/pgsql/data/base/
> 5.7M    /opt/data/pgsql/data/base/1
> 5.7M    /opt/data/pgsql/data/base/16862
> 5.7M    /opt/data/pgsql/data/base/16863
> 5.7M    /opt/data/pgsql/data/base/16864
> 6.3M    /opt/data/pgsql/data/base/16865
> 5.7M    /opt/data/pgsql/data/base/16866
> 35M     /opt/data/pgsql/data/base
> 
> 
> Joe
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026