Re: ecpg - GRANT bug

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: ecpg - GRANT bug
Дата
Msg-id 200110161356.f9GDubf12987@candle.pha.pa.us
обсуждение исходный текст
Ответ на Re: ecpg - GRANT bug  (Lee Kindness <lkindness@csl.co.uk>)
Список pgsql-hackers
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


> Lee Kindness writes:
>  > Patch below, it changes:
>  >  1. A number of mmerror(ET_ERROR) to mmerror(ET_NOTICE), passing on
>  >     the (currently) unsupported options to the backend with warning.
>  >  2. Standardises warning messages in such cases.
>  >  3. Corrects typo in passing of 'CREATE FUNCTION/INOUT' parameter.
> 
> And the patch below corrects a pet peeve I have with ecpg, all errors
> and warnings are output with a line number one less than reality...
> 
> Lee.
> 
> *** ./interfaces/ecpg/preproc/preproc.y.orig    Tue Oct 16 10:19:27 2001
> --- ./interfaces/ecpg/preproc/preproc.y    Tue Oct 16 10:19:49 2001
> ***************
> *** 36,49 ****
>       switch(type)
>       {
>       case ET_NOTICE: 
> !         fprintf(stderr, "%s:%d: WARNING: %s\n", input_filename, yylineno, error); 
>           break;
>       case ET_ERROR:
> !         fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename, yylineno, error);
>           ret_value = PARSE_ERROR;
>           break;
>       case ET_FATAL:
> !         fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename, yylineno, error);
>           exit(PARSE_ERROR);
>       }
>   }
> --- 36,52 ----
>       switch(type)
>       {
>       case ET_NOTICE: 
> !         fprintf(stderr, "%s:%d: WARNING: %s\n", input_filename,
> !             yylineno + 1, error); 
>           break;
>       case ET_ERROR:
> !         fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename,
> !             yylineno + 1, error);
>           ret_value = PARSE_ERROR;
>           break;
>       case ET_FATAL:
> !         fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename,
> !             yylineno + 1, error);
>           exit(PARSE_ERROR);
>       }
>   }
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Lee Kindness
Дата:
Сообщение: delayed mail?
Следующее
От: Denis A Ustimenko
Дата:
Сообщение: compiling on Solaris 8 x86