Re: patch for spelling mistake

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: patch for spelling mistake
Дата
Msg-id 200107110058.f6B0wUa23680@candle.pha.pa.us
обсуждение исходный текст
Ответ на Re: patch for spelling mistake  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: patch for spelling mistake  (Neil Conway <nconway@klamath.dyndns.org>)
Список pgsql-patches
> nconway@klamath.dyndns.org (Neil Conway) writes:
> > I think I made the patch properly; from the root of the 'pgsql'
> > CVS module, apply with: patch -p0 < patchfile.
>
> diff -c output is preferred.  A plain diff such as you have here has too
> little context to be safe to apply (if someone else has edited the file
> since the version you diffed from, a plain diff patch is much too likely
> to be applied incorrectly).

Tom is right, diff -c is best, though in the patch you applied, there is
no chance for error so I can accept it.  You have unique previous text
for each change.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: [GENERAL] 2 gig file size limit
Следующее
От: Neil Conway
Дата:
Сообщение: Re: patch for spelling mistake