Re: Cygwin PostgreSQL ESQL Patch

Поиск
Список
Период
Сортировка
От Jason Tishler
Тема Re: Cygwin PostgreSQL ESQL Patch
Дата
Msg-id 20010420153856.A169@dothill.com
обсуждение исходный текст
Ответ на Re: Cygwin PostgreSQL ESQL Patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Cygwin PostgreSQL ESQL Patch
Список pgsql-patches
On Fri, Apr 20, 2001 at 02:38:53PM -0400, Tom Lane wrote:
> Jason Tishler <Jason.Tishler@dothill.com> writes:
> > In the above mentioned URL, I suggested including c.h as another
> > possibly better solution.  However, I saw the following in ecpglib.h:
> >     /*
> >      * this is a small part of c.h since we don't want to leak all postgres
> >      * definitions into ecpg programs
> >      */
> > so I decided against including c.h in the first version of my patch.
>
> That's a fair point.  Maybe it should be
>
> +#ifndef DLLIMPORT
> +#ifdef __CYGWIN__
> +#define DLLIMPORT __declspec (dllimport)
> +#else
> +#define DLLIMPORT
> +#endif /* __CYGWIN__ */
> +#endif /* DLLIMPORT */

I will redo my patch with the modification suggested above.

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Cygwin PostgreSQL ESQL Patch
Следующее
От: Peter T Mount
Дата:
Сообщение: Re: [JDBC] PATCH: JDBC compile w/ jikes