Re: new version of contrib-intarray

I checked README.intarray to see what the most recent date was, and it
was Jan 10, so I knew that this version was newer.  I then did a diff -c
against the current CVS and I didn't see anything unusual in the
changes.

Attached is the CVS diff command line showing me all the changes made:

   cvs  diff -c -D '2001-01-13 00:00:00' -D'2001-03-16 00:00:00' .

I see change of += in CFLAGS (harmless), movement of #include
<postgres.h>, and removal of // comments, which don't appear anymore in
the code.

Do you see anything else?  This one was easy to track because it was
installed only recently, but other /contrib stuff is much tougher
because you never know what the original install date was.

I usually only look at Makefile changes in /contrib because that is
where most of the customization is, and I don't see any changes made to
Makefile by the patch.  It doesn't even touch the CFLAGS += change.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
? Makefile.703
Index: Makefile
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/contrib/intarray/Makefile,v
retrieving revision 1.2
retrieving revision 1.3
diff -c -r1.2 -r1.3
*** Makefile    2001/01/13 02:18:31    1.2
--- Makefile    2001/02/20 19:20:27    1.3
***************
*** 1,4 ****
! # $Header: /home/projects/pgsql/cvsroot/pgsql/contrib/intarray/Makefile,v 1.2 2001/01/13 02:18:31 petere Exp $

  subdir = contrib/intarray
  top_builddir = ../..
--- 1,4 ----
! # $Header: /home/projects/pgsql/cvsroot/pgsql/contrib/intarray/Makefile,v 1.3 2001/02/20 19:20:27 petere Exp $

  subdir = contrib/intarray
  top_builddir = ../..
***************
*** 12,18 ****
  SO_MAJOR_VERSION= 1
  SO_MINOR_VERSION= 0

! override CPPFLAGS += -I$(srcdir) -DPGSQL71

  OBJS= _int.o

--- 12,18 ----
  SO_MAJOR_VERSION= 1
  SO_MINOR_VERSION= 0

! override CPPFLAGS := -I$(srcdir) $(CPPFLAGS) -DPGSQL71

  OBJS= _int.o

Index: _int.c
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/contrib/intarray/_int.c,v
retrieving revision 1.1
retrieving revision 1.3
diff -c -r1.1 -r1.3
*** _int.c    2001/01/12 00:16:23    1.1
--- _int.c    2001/02/12 18:30:52    1.3
***************
*** 4,14 ****
    format for these routines is dictated by Postgres architecture.
  ******************************************************************************/

! #include <stdio.h>
  #include <float.h>
  #include <string.h>

- #include "postgres.h"
  #include "access/gist.h"
  #include "access/itup.h"
  #include "access/rtree.h"
--- 4,14 ----
    format for these routines is dictated by Postgres architecture.
  ******************************************************************************/

! #include "postgres.h"
!
  #include <float.h>
  #include <string.h>

  #include "access/gist.h"
  #include "access/itup.h"
  #include "access/rtree.h"
***************
*** 194,200 ****

  #ifdef GIST_DEBUG
      elog(NOTICE, "COMP IN: %d leaf; %d rel; %d page; %d offset; %d bytes; %d elems", entry->leafkey, (int)entry->rel,
(int)entry->page,(int)entry->offset, (int)entry->bytes, len); 
!     //printarr( r, len );
  #endif

      if ( len >= 2*MAXNUMRANGE ) {  /*compress*/
--- 194,200 ----

  #ifdef GIST_DEBUG
      elog(NOTICE, "COMP IN: %d leaf; %d rel; %d page; %d offset; %d bytes; %d elems", entry->leafkey, (int)entry->rel,
(int)entry->page,(int)entry->offset, (int)entry->bytes, len); 
!     /* printarr( r, len ); */
  #endif

      if ( len >= 2*MAXNUMRANGE ) {  /*compress*/
***************
*** 260,266 ****

  #ifdef GIST_DEBUG
      elog(NOTICE, "DECOMP IN: %d leaf; %d rel; %d page; %d offset; %d bytes; %d elems", entry->leafkey,
(int)entry->rel,(int)entry->page, (int)entry->offset, (int)entry->bytes, lenin); 
!     //printarr( in, lenin );
  #endif

      lenr = internal_size(din, lenin);
--- 260,266 ----

  #ifdef GIST_DEBUG
      elog(NOTICE, "DECOMP IN: %d leaf; %d rel; %d page; %d offset; %d bytes; %d elems", entry->leafkey,
(int)entry->rel,(int)entry->page, (int)entry->offset, (int)entry->bytes, lenin); 
!     /* printarr( in, lenin ); */
  #endif

      lenr = internal_size(din, lenin);
***************
*** 653,659 ****
      int i,j;

  #ifdef GIST_DEBUG
!     //elog(NOTICE, "inner_union %d %d", ARRISNULL( a ) , ARRISNULL( b ) );
  #endif

      if ( ARRISNULL( a ) && ARRISNULL( b ) ) return new_intArrayType(0);
--- 653,659 ----
      int i,j;

  #ifdef GIST_DEBUG
!     /* elog(NOTICE, "inner_union %d %d", ARRISNULL( a ) , ARRISNULL( b ) ); */
  #endif

      if ( ARRISNULL( a ) && ARRISNULL( b ) ) return new_intArrayType(0);
***************
*** 709,715 ****
      int i,j;

  #ifdef GIST_DEBUG
!     //elog(NOTICE, "inner_inter %d %d", ARRISNULL( a ), ARRISNULL( b ) );
  #endif

      if ( ARRISNULL( a ) || ARRISNULL( b ) ) return NULL;
--- 709,715 ----
      int i,j;

  #ifdef GIST_DEBUG
!     /* elog(NOTICE, "inner_inter %d %d", ARRISNULL( a ), ARRISNULL( b ) ); */
  #endif

      if ( ARRISNULL( a ) || ARRISNULL( b ) ) return NULL;