Tom,
On Sat, Dec 30, 2000 at 10:56:43PM -0500, Tom Lane wrote:
> Jason Tishler <Jason.Tishler@dothill.com> writes:
> > --- postgresql-20001229.orig/src/backend/utils/mmgr/mcxt.c Tue Aug 22 03:00:13 2000
> > +++ postgresql-20001229/src/backend/utils/mmgr/mcxt.c Fri Dec 29 23:46:31 2000
> > @@ -45,7 +45,7 @@ MemoryContext PostmasterContext = NULL;
> > MemoryContext CacheMemoryContext = NULL;
> > MemoryContext QueryContext = NULL;
> > MemoryContext TopTransactionContext = NULL;
> > -MemoryContext TransactionCommandContext = NULL;
> > +DLLIMPORT MemoryContext TransactionCommandContext = NULL;
>
> These changes look fine as far as they go, but if you think
> TransactionCommandContext needs to be DLLIMPORT, why not the other
> global context variables, too?
I took the minimalist approach -- meaning that I only made the minimum
number of changes necessary to get PostgreSQL to compile cleanly under
Cygwin. You are correct, the other global context variables should
also be marked DLLIMPORT. There are probably other global variables
that should be marked too.
The completeness approach would DLLIMPORT "everything" (similar to
the way that Python uses DL_EXPORT), but that would be a lot of source
code changes...
> What led you to mark it DLLIMPORT anyway?
I marked TransactionCommandContext as DLLIMPORT to get plpgsql.dll to
link without unresolved symbol errors.
Jason
--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corporation Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com