Re: CURRENT/OLD keywords still broken

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: CURRENT/OLD keywords still broken
Дата
Msg-id 200012152258.RAA08165@candle.pha.pa.us
обсуждение исходный текст
Ответ на CURRENT/OLD keywords still broken  (Peter Eisentraut <peter_e@gmx.net>)
Ответы Re: CURRENT/OLD keywords still broken  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: CURRENT/OLD keywords still broken  (Peter Eisentraut <peter_e@gmx.net>)
Список pgsql-hackers
> peter=# select 1 as current;
>  old
> -----
>    1
> 
> This is now the inverse of what it used to do, but it's still not what it
> *should* do.  I see someone already tried to fix that (keywords.c 1.76 ->
> 1.77, TODO list), but he should try again.

That was me.  The old code did old -> current, so I changed it to do
current -> old.  How else can I fix this?  Attached is the old patch.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026 
Index: keywords.c
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/parser/keywords.c,v
retrieving revision 1.76
retrieving revision 1.77
diff -c -r1.76 -r1.77
*** keywords.c    2000/06/12 03:40:30    1.76
--- keywords.c    2000/06/12 19:40:41    1.77
***************
*** 9,17 ****  *  * IDENTIFICATION <<<<<<< keywords.c
!  *      $Header: /home/projects/pgsql/cvsroot/pgsql/src/backend/parser/keywords.c,v 1.76 2000/06/12 03:40:30 momjian
Exp$ =======
 
!  *      $Header: /home/projects/pgsql/cvsroot/pgsql/src/backend/parser/keywords.c,v 1.76 2000/06/12 03:40:30 momjian
Exp$ >>>>>>> 1.73  *  *-------------------------------------------------------------------------
 
--- 9,17 ----  *  * IDENTIFICATION <<<<<<< keywords.c
!  *      $Header: /home/projects/pgsql/cvsroot/pgsql/src/backend/parser/keywords.c,v 1.77 2000/06/12 19:40:41 momjian
Exp$ =======
 
!  *      $Header: /home/projects/pgsql/cvsroot/pgsql/src/backend/parser/keywords.c,v 1.77 2000/06/12 19:40:41 momjian
Exp$ >>>>>>> 1.73  *  *-------------------------------------------------------------------------
 
***************
*** 77,82 ****
--- 77,84 ----     {"createdb", CREATEDB},     {"createuser", CREATEUSER},     {"cross", CROSS},
+     /* for portability with old rules bjm 2000-06-12 */
+     {"current", OLD},     {"current_date", CURRENT_DATE},     {"current_time", CURRENT_TIME},
{"current_timestamp",CURRENT_TIMESTAMP},
 
***************
*** 183,189 ****     {"off", OFF},     {"offset", OFFSET},     {"oids", OIDS},
!     {"old", CURRENT},     {"on", ON},     {"only", ONLY},     {"operator", OPERATOR},
--- 185,191 ----     {"off", OFF},     {"offset", OFFSET},     {"oids", OIDS},
!     {"old", OLD},     {"on", ON},     {"only", ONLY},     {"operator", OPERATOR},

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: CURRENT/OLD keywords still broken
Следующее
От: "Mikheev, Vadim"
Дата:
Сообщение: RE: TOAST-table vacuuming (was Re: Idea for reducing pl anning time)